Add descriptive docstring for _get_phases in CZLayerGate#467
Merged
mhucka merged 2 commits intoApr 15, 2026
Merged
Conversation
Replaced the "TODO" docstring with a detailed description of the parameters and return value for the _get_phases method, clarifying its role in the CZLayerGate's decomposition.
dstrain115
approved these changes
Apr 15, 2026
shashwatk1998
pushed a commit
to shashwatk1998/ReCirq
that referenced
this pull request
Apr 21, 2026
…#467) Replaced the "TODO" docstring with a detailed description of the parameters and return value for the _get_phases method, clarifying its role in the CZLayerGate's decomposition.
mhucka
added a commit
to mhucka/ReCirq
that referenced
this pull request
Apr 23, 2026
* Add RCS experiment * typo * fix docstrings * Add Gemini Code Assist config file (quantumlib#462) This configures Gemini Code Assist to be a little bit less noisy and verbose. Based on experiences with other repos, I find this makes Gemini more useful. * addressed comments * Fix incompatible return value found by typecheck And make it bit more apparent how is `RCSResults._fidelities_lin` set. Fixes mypy recirq/random_circuit_sampling | grep random_circuit * Update recirq/random_circuit_sampling/rcs_experiment.py Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com> * Update recirq/random_circuit_sampling/rcs_experiment.py Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com> * Update recirq/random_circuit_sampling/rcs_experiment.py Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com> * addressed Alexis's comments * docs: add demonstration notebook for RCS and XEB analysis * update characterize_pairs and add a test for it using ideal fSim gates * addressed the comments on the notebook * Add descriptive docstring for _get_phases in CZLayerGate. (quantumlib#467) Replaced the "TODO" docstring with a detailed description of the parameters and return value for the _get_phases method, clarifying its role in the CZLayerGate's decomposition. * Update Scorecard workflow (quantumlib#471) This updates the workflow to the latest version used in our other projects. It fixes a number of flaws, such as the use of a merge group trigger (which causes errors when Scorecard is run on a branch). * Remove no-longer-used dev_tools/docs/sphinx/ (quantumlib#472) * addressed comments * Improved the introduction and added a conclusion --------- Co-authored-by: Shashwat Kumar <kshashwat@google.com> Co-authored-by: Michael Hucka <mhucka@google.com> Co-authored-by: Pavol Juhas <juhas@google.com> Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the "TODO" docstring with a detailed description of the parameters and return value for the _get_phases method, clarifying its role in the CZLayerGate's decomposition.